1
0
Fork 0
Commit Graph

44 Commits (5cb517faba611ca99f4cf76761f448424f24d8ee)

Author SHA1 Message Date
Nils Dagsson Moskopp adf738854a
Fix mob-in-boat crash in Minetest 5.5-dev
In Minetest 5.4.1, calling get_player_control() on a mob returned the
empty string. Minetest commit 5eb45e1ea03c6104f007efec6dd9c351f310193d
changed this, so now calling get_player_control() on a mob returns nil.

As mcl_boats defines boats that can have a player or a mob as a driver,
code like the following crashes with a changed get_player_control() API:

local ctrl = driver:get_player_control()
if ctrl.sneak then
    detach_object(driver, true)
end

Furthermore, once a world has crashed, joining it near a mob that is the
driver of a boat with such control code immediately crashes again.

When I reported this bug to Minetest, several Minetest core developers
stated that they disliked the old API and proposed other return values
for calling a mob's get_player_control() function – all different from
the empty string. Since I have some doubts that this bug will be fixed
in Minetest 5.5.0, boat code must take into account a nil return value.

Minetest issue: https://github.com/minetest/minetest/issues/11989
2022-02-15 11:17:01 +01:00
Nils Dagsson Moskopp 46394e7e1f
Add obsidian boat that always sinks 2021-11-20 09:06:48 +01:00
Elias Fleckenstein a7bc460fae
Fix boat and enchanting book texture glitches / warnings 2021-11-09 17:39:39 +01:00
AFCMS c31c852a6e add documentation 2021-07-20 16:14:34 +02:00
AFCMS b5f7ae5458 working implementation + support of other mods 2021-07-20 15:47:26 +02:00
AFCMS cd33d406b2 fix many codestyle issues (functions, strings, modpaths) 2021-05-29 16:12:33 +02:00
AFCMS be9fff4fe2 [mcl_boats] fix warnings 2021-05-25 00:50:04 +02:00
Elias Fleckenstein a2983e1fda Update boats translation 2021-04-26 10:17:07 +02:00
Elias Fleckenstein 9eba2add3f Rewrite burning API 2021-04-25 13:09:20 +02:00
epCode 97424f7d0a Fix #1414 2021-03-30 10:24:39 -07:00
AFCMS 3a514ecdad remove duplicated code 2021-03-30 00:44:38 +02:00
Elias Fleckenstein 6f8d0d4de0 Fix #1375 2021-03-26 17:51:13 +01:00
Elias Fleckenstein 413fbc9c60 Make boats burn (Fix #1318) 2021-03-18 12:31:25 +01:00
AFCMS 6645c4cb30 Really 2021-03-16 17:43:32 +01:00
Elias Fleckenstein 8d5b2ff714 Make boats less annoying on ice 2021-02-27 14:38:53 +01:00
Elias Fleckenstein 0c3ab5843d Make boats go super fast on ice and slightly faster on land 2021-02-24 10:38:49 +01:00
Elias Fleckenstein 0d2950228a Implement #1057 2021-02-24 09:31:27 +01:00
Elias Fleckenstein 2d4b8a8232 Replace usages of get_node_group by get_item_group 2021-02-23 10:25:17 +01:00
Elias Fleckenstein 2d0612fa81 Make boats regenerate health and shake when damaged 2021-02-22 12:43:29 +01:00
Elias Fleckenstein c9e589b931 Add mcl_burning damage interval 2021-02-18 14:47:35 +01:00
Elias Fleckenstein 9956e267aa Allow for 2 drivers in a boat 2021-01-31 12:54:40 +01:00
Elias Fleckenstein e66d66caf9 Fix #399 2021-01-28 19:02:44 +01:00
Elias Fleckenstein 89ce072621 Sneak to dismount when in boat 2021-01-28 17:44:55 +01:00
Elias Fleckenstein eb01c8e9f8 Give boats HP (Closes #991) 2021-01-24 16:27:04 +01:00
Elias Fleckenstein 507f2d872b Fix #949 2021-01-04 14:21:28 +01:00
Wuzzy c106a62979 Use minetest.is_creative_enabled 2020-07-10 16:45:40 +02:00
Wuzzy ba74546d48 Add extended tooltips 2020-02-19 04:54:17 +01:00
Wuzzy 4a7aaa9024 Increase boat speed on land 2019-10-02 20:54:06 +02:00
Wuzzy a9ed14c4af Fix boats moving too fast backwards 2019-10-02 20:51:02 +02:00
Wuzzy 30a954b874 Increase max. speed of boats 2019-09-11 13:33:31 +02:00
Wuzzy e633f15eed Fix boat behavior a bit when falling on water 2019-09-11 12:50:58 +02:00
Wuzzy df7acfc8ae Boats: Can place properly at all sides 2019-09-11 12:23:56 +02:00
Wuzzy b6c3cc0ed7 Tweak boat physics when inside water 2019-09-11 12:11:04 +02:00
Wuzzy 3cba55703a Boats: Allow very slow movement on ground 2019-09-11 11:17:42 +02:00
Wuzzy 1217d9fa88 New translation system, part 1: entities 2019-03-07 20:43:39 +01:00
Wuzzy a9776814a6 Fix player attachment offsets 2019-03-06 05:11:49 +01:00
Wuzzy 2f74aea6f5 Replace deprecated functions 2019-03-06 04:38:57 +01:00
Wuzzy d59d789c80 Put boat/minecart in inv when punched in creative 2019-02-06 21:56:52 +01:00
Wuzzy e789801662 Replace getpos() with get_pos() 2019-02-01 06:33:07 +01:00
Wuzzy f022b747b0 Harden a number of minetest.after player checks 2018-06-03 16:44:37 +02:00
Wuzzy f0b732d7e0 Place boats in the placer direction 2018-05-09 18:43:07 +02:00
Wuzzy fa10dc93ae Add _on_dispense callback for dispenser; refactor 2018-02-01 22:49:41 +01:00
Wuzzy e5a34367c9 Use new Minetest settings API syntax for most mods 2017-08-09 16:17:00 +02:00
Wuzzy e90b80ab26 Move 3 mods to ENTITIES 2017-07-27 04:07:38 +02:00