Commit Graph

308 Commits (168a018b00b6581a2bcd10583393ecace877a838)

Author SHA1 Message Date
Flaparoo cde7efad99 widget_utils: use correct variable to clear interval 2024-01-09 12:04:20 +08:00
thyttan 71a445c96e Slider: formatting Slider.md 2023-10-18 23:20:46 +02:00
thyttan 8bd1cbb2a8 Slider: add to documentation re timeout 2023-10-18 23:14:03 +02:00
thyttan 05e2ff899c Slider: add to documentation Slider.md 2023-10-18 21:55:59 +02:00
thyttan 03a1f10d45 Slider: auto indentation 2023-10-18 01:18:57 +02:00
thyttan bdf7aab65c Slider: remove development try-catch statement 2023-10-18 01:16:15 +02:00
thyttan 04c5cbd516 Slider: update documentation 2023-10-18 01:06:21 +02:00
thyttan 4d7bcce070 Slider: remove unnecessary spaces 2023-10-18 00:35:42 +02:00
thyttan 5156b8a3e5 Slider:add param for auto progress update interval 2023-10-18 00:17:59 +02:00
thyttan 4d6edb1292 Slider: add missing semicolons 2023-10-17 23:21:56 +02:00
thyttan 6c1fb8cc18 Slider: shrink borders if too big
... which would cause glitches.
2023-10-17 22:49:32 +02:00
thyttan 0c12bfab8a Slider: move and refactor step size calculation 2023-10-17 22:49:32 +02:00
thyttan 7e01449705 Slider: remove unnecessary condition check 2023-10-17 22:49:32 +02:00
thyttan eb52a9aca4 Slider: update documentation at Slider.md 2023-10-17 22:49:32 +02:00
thyttan c4ba51a498 Slider: fix logic re roundedness 2023-10-17 22:49:32 +02:00
thyttan cd67e0d143 Slider: add comment tags 2023-10-17 22:49:32 +02:00
thyttan ac27deba0f Slider: scale default borders with appRect width 2023-10-17 22:49:32 +02:00
thyttan 0fbcb34896 Slider: remove two lines of debug 2023-10-17 22:49:32 +02:00
thyttan 0a1e3a6590 Slider: add initial comments 2023-10-17 22:49:32 +02:00
thyttan 186832faa4 Slider:make rounded mode dynamic, depend on width
Fixes graphics for different size sliders.
2023-10-17 22:49:32 +02:00
thyttan b2a72dccc7 Slider: move let statement out of function scope 2023-10-17 22:49:32 +02:00
thyttan 9d532a82d9 Slider: fix callback running prematurely 2023-10-17 22:49:32 +02:00
thyttan 962d87442e Slider: add `FIXME:` comment re error in callback 2023-10-17 22:49:32 +02:00
thyttan ee5e08d8fe Slider: add level to auto callback 2023-10-17 22:49:32 +02:00
thyttan bbb2907a54 Slider:update `currLevel`->`initLevel`, and tweaks 2023-10-17 22:49:32 +02:00
thyttan ac568fb332 Slider: change `currLevel` -> `initLevel` 2023-10-17 22:49:32 +02:00
thyttan 8cf9cd77bb Slider: add tip to Slider.md, and tweaks 2023-10-17 22:49:32 +02:00
thyttan 070d3d4f1d Slider: update Slider.md re mode:"incr"/"map" 2023-10-17 22:49:32 +02:00
thyttan fae1025494 Slider: fix Slider.md code blocks 2023-10-17 22:49:32 +02:00
thyttan 9b882c24bd Slider: refactor useIncr/Map -> mode:"incr"/"map"/
/"mapincr"

Thanks @bobrippling
2023-10-17 22:49:32 +02:00
thyttan 3afd9ac126 Slider: remove unnecessary var initialization
Co-authored-by: Rob Pilling <robpilling@gmail.com>
2023-10-17 22:49:32 +02:00
thyttan 3adb21d035 Slider: shorten conditional assignment logic
Co-authored-by: Rob Pilling <robpilling@gmail.com>
2023-10-17 22:49:32 +02:00
thyttan 40c205c042 Slider: callback first, then draw
as per: https://github.com/espruino/BangleApps/pull/2953#discussion_r1350097601

To still be able to draw on top of the slider, in the callback wrap the extra drawing inside a `setTimeout(extraDraw,0)` or similar.

Thanks @bobrippling!
2023-10-17 22:49:32 +02:00
thyttan 93112f40df Slider: fix cbObj undefined 2023-10-17 22:49:32 +02:00
thyttan 01cf0fb202 Slider: disregard laziness on max/min levels 2023-10-17 22:49:32 +02:00
thyttan bcb6e0ca01 Slider: ask what the screens height is
Should make this more likely to work on different size screens.
2023-10-17 22:49:32 +02:00
thyttan 408990d919 Slider:move draw and cb to deduplicate code 2023-10-17 22:49:32 +02:00
thyttan 944da80186 Slider: reorder default config values 2023-10-17 22:49:32 +02:00
thyttan 795fec654e Slider: tweak documentation in slider.md 2023-10-17 22:49:32 +02:00
thyttan a9562b844f Slider:use actual current level for auto progress 2023-10-17 22:49:32 +02:00
thyttan 9b1cfd4836 Slider: `ebLast` and `dy` only needed with draging 2023-10-17 22:49:32 +02:00
thyttan 17f72c680e Slider: tweaks to Slider.md documentation 2023-10-17 22:49:32 +02:00
thyttan a238086266 Slider: Add some descriptive comments 2023-10-17 22:49:32 +02:00
thyttan 9c4fd1d94c Slider: Add some documentation 2023-10-17 22:49:32 +02:00
thyttan 573fa3806c Slider: remove some unused vars and consts 2023-10-17 22:49:32 +02:00
thyttan ecd4a7ee0c Slider: Assign empty function to cb if undefined 2023-10-17 22:49:32 +02:00
thyttan 0952ad9a26 Slider: refactor logic re auto progressing sliders 2023-10-17 22:49:32 +02:00
thyttan 98a6417008 Slider: move `let incr` into `while` scope 2023-10-17 22:49:32 +02:00
thyttan 2444e75628 Slider: small refactor to shorten code 2023-10-17 22:49:32 +02:00
thyttan b9c5245ba0 Slider:tweak code re zero level on rounded sliders 2023-10-17 22:49:32 +02:00