1
0
Fork 0
MineClone2/mods/ITEMS/mcl_core
𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 a620d24ec8 Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914)
Fixes: #3913 #3915

~~You can reproduce the crash by placing a fish bucket on top snow above an unknown node.

I also noticed that the code always uses pointed_thing.above so I fixed that and also added a function to mcl_utils to figure out where a node should be placed (either above or below). Looks like the rest of the code could also use improvement but at least it does not crash now.~~

Cora fixed a bunch of related crashes in Mineclona so I am replacing my commit and cherry picking all her commits here.
https://codeberg.org/mineclonia/mineclonia/pulls/549

Here is the list of fixes from that PR:
- Crash when placing snow layer on unknown nodes
- Crash when snow layers on unknown nodes are flooded
- Crash when placing fishbucket on snow on top of unknown nodes
- Crash when placing chorus flower and stem on unknown
- Crash when placing mob spawners on unknown
- The fishbucket on place to actually replace buildable_to

Co-authored-by: cora <coradelamouche@gmx.ch>
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3914
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
Co-committed-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
2023-09-29 18:47:07 +00:00
..
locale Update Russian translation. Fix 1. 2023-09-02 15:51:49 +08:00
schematics Add Bee Nest Tree Schematics and generation 2022-11-17 03:16:45 +01:00
sounds Convert all sounds (except music) to mono 2017-11-13 01:24:24 +01:00
README.txt Grow proper acacia tree from acacia saplings 2017-05-26 02:36:25 +02:00
crafting.lua Separate white dye from bone meal. 2022-12-29 03:08:50 +00:00
craftitems.lua Separate blue dye from lapis lazuli. 2022-12-29 03:08:49 +00:00
functions.lua Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
init.lua fix many codestyle issues (functions, strings, modpaths) 2021-05-29 16:12:33 +02:00
mod.conf MAKE EVERY SINGLE MOD USE PROPER COLORS!!! 2021-03-30 00:01:29 +02:00
nodes_base.lua Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914) 2023-09-29 18:47:07 +00:00
nodes_cactuscane.lua Add grass palette nodes in a special group 2023-03-05 12:45:44 +00:00
nodes_climb.lua Improve vines code 2023-02-14 18:11:43 +00:00
nodes_glass.lua framed stained glass 2021-12-23 18:02:43 +01:00
nodes_liquid.lua Improve water 2023-02-18 08:21:24 +00:00
nodes_misc.lua Prevent slime blocks from 'connecting' to honey blocks when pushing/pulling, like in Minecraft. 2023-06-17 16:42:06 +02:00
nodes_trees.lua Ensure dark oak has separate tt message 2023-06-25 16:37:02 +00:00

README.txt

MineClone 2 core mod
====================
Originally forked from Minetest Game's default mod in the distant past.

License information
===================

License of source code:
-----------------------
Copyright (C) 2011-2012 celeron55, Perttu Ahola <celeron55@gmail.com>

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as published by
the Free Software Foundation; either version 2.1 of the License, or
(at your option) any later version.

License of all textures and sounds
----------------------------------
MIT License.

The textures are taken from the Minecraft resource pack “Faithful 1.11” by Vattic and
xMrVizzy and contributers.

Sounds
======
All sounds included in this mod are under the MIT License.
The other sounds used in this mod can be found in CORE/mcl_sounds.

http://www.gnu.org/licenses/lgpl-2.1.html

License of everything not listed here
-------------------------------------
celeron55, Perttu Ahola <celeron55@gmail.com>
CC BY-SA 3.0 <https://creativecommons.org/licenses/by-sa/3.0/>