1
0
Fork 0
Commit Graph

43 Commits (487f78d66320c73c1817789c8370a69a6ea065f5)

Author SHA1 Message Date
𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 a620d24ec8 Fix a number of crashes involving unknown nodes, also fix fishbuckets on_place (#3914)
Fixes: #3913 #3915

~~You can reproduce the crash by placing a fish bucket on top snow above an unknown node.

I also noticed that the code always uses pointed_thing.above so I fixed that and also added a function to mcl_utils to figure out where a node should be placed (either above or below). Looks like the rest of the code could also use improvement but at least it does not crash now.~~

Cora fixed a bunch of related crashes in Mineclona so I am replacing my commit and cherry picking all her commits here.
https://codeberg.org/mineclonia/mineclonia/pulls/549

Here is the list of fixes from that PR:
- Crash when placing snow layer on unknown nodes
- Crash when snow layers on unknown nodes are flooded
- Crash when placing fishbucket on snow on top of unknown nodes
- Crash when placing chorus flower and stem on unknown
- Crash when placing mob spawners on unknown
- The fishbucket on place to actually replace buildable_to

Co-authored-by: cora <coradelamouche@gmx.ch>
Reviewed-on: https://git.minetest.land/MineClone2/MineClone2/pulls/3914
Reviewed-by: ancientmarinerdev <ancientmariner_dev@proton.me>
Co-authored-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
Co-committed-by: 𝕵𝖔𝖍𝖆𝖓𝖓𝖊𝖘 𝕱𝖗𝖎𝖙𝖟 <mrrar@noreply.git.minetest.land>
2023-09-29 18:47:07 +00:00
ancientmarinerdev 1c0387b898 Fix warnings and global vars 2023-03-21 22:20:26 +00:00
GuyLiner e99a46b52d Removed comment 2023-02-16 20:48:30 -05:00
GuyLiner 48b16a23b6 If player in creative mode, don't drop experience from destroyed spawners 2023-02-16 19:43:50 -05:00
Elias Fleckenstein ff33794487 Rename mobs global to mcl_mobs 2022-05-25 23:13:33 +02:00
Glaucos Ginez 9edf277905 Fix mobs spawn count 2021-11-21 22:13:24 -03:00
Elias Fleckenstein a4e73886d5
Rework XP API 2021-11-03 19:36:57 +01:00
epCode 1c458a2e72 Add crossbows 2021-10-15 12:00:37 -07:00
AFCMS cd33d406b2 fix many codestyle issues (functions, strings, modpaths) 2021-05-29 16:12:33 +02:00
AFCMS 0113d290b7 [mcl_mobspawners] fix warnings 2021-05-22 23:19:31 +02:00
kay27 31b56e77ee [mcl_mobspawners] Remove a typo (tab character) 2021-05-08 14:12:13 +04:00
kay27 4bb27a0d79 [mcl_mobspawners] Fix random crash, https://git.minetest.land/MineClone2/MineClone2/issues/1707 2021-05-08 14:09:16 +04:00
AFCMS 8f30e223e2 I hate reverting something xD 2021-03-16 17:39:06 +01:00
Elias Fleckenstein 6780031454 Fix #1181 2021-02-24 08:33:35 +01:00
Elias Fleckenstein 69959fe816 Fix #1142 2021-02-18 08:58:28 +01:00
Elias Åström 6315490b14 Update the rest of the blast resistance values
The values have been updated according to this list:

https://minecraft.gamepedia.com/Module:Blast_resistance_values
2020-04-19 13:08:36 +02:00
Wuzzy ba74546d48 Add extended tooltips 2020-02-19 04:54:17 +01:00
Wuzzy 1c27cbe4f6 German translation: mcl_mobitems to mcl_potions 2019-03-15 09:50:32 +01:00
Wuzzy f373f3a4f1 Mob spawner: Reduce spawn count for big mobs 2019-03-08 23:26:54 +01:00
Wuzzy 47c817d75a New translation system, part 8: Items, part 4 2019-03-08 00:22:28 +01:00
Wuzzy 66c6b373a5 Make many entities non-pointable 2019-03-07 03:53:06 +01:00
Wuzzy 2f74aea6f5 Replace deprecated functions 2019-03-06 04:38:57 +01:00
Wuzzy e5c78973b0 Respawn mobspawner doll on load, if gone mobspawner doll on load, if gone mobspawner doll on load, if gone mobspawner doll on load, if gone 2019-02-19 00:06:14 +01:00
Wuzzy c141f4ece5 Mobspawners: Remove unused function 2019-02-08 22:20:58 +01:00
Wuzzy e789801662 Replace getpos() with get_pos() 2019-02-01 06:33:07 +01:00
Wuzzy 7196485294 Remove sunlight propagation for various nodes 2018-01-28 20:21:02 +01:00
Wuzzy b133dd6d5b Mob spawner: Fix mob sometimes not set correctly 2018-01-08 16:10:42 +01:00
Wuzzy a7425b37b5 Extend mobspawner help 2018-01-08 02:19:00 +01:00
Wuzzy a818995d2a Generated mob spawners generate mobs in darkness (except silverfish) 2018-01-08 00:41:57 +01:00
Wuzzy c2161b59f4 Fix witch doll size in mob spawner 2018-01-07 17:54:40 +01:00
Wuzzy ac8d284fab Fix broken mobspawner doll textures for 4 mobs 2018-01-07 17:50:50 +01:00
Wuzzy 777d8403e8 Mobspawner: Fix overlarge dolls for large mobs 2018-01-07 17:29:56 +01:00
Wuzzy 3cf6656df2 Rename "Monster Spawner" to "Mob Spawner" 2018-01-07 16:58:44 +01:00
Wuzzy cc411efe4c Move mob spawner change code to mobs mod 2018-01-07 16:53:25 +01:00
Wuzzy 1a96ef137a Allow to change monster spawner mob with spawn egg 2018-01-07 16:37:41 +01:00
Wuzzy 3f0bfa0aa8 Add maphack privilege for advanced blocks like command blocks 2017-12-13 00:30:23 +01:00
Wuzzy f1215ca989 Add spawner placement instructions 2017-08-15 14:19:44 +02:00
Wuzzy 3845369237 Fix generated mob spawners sometimes have pig 2017-08-15 14:16:40 +02:00
Wuzzy 0f10f980a9 Document the mobspawner doll spawning bug 2017-08-14 17:23:43 +02:00
Wuzzy 1814fe5ea5 Remove minetest.env in mcl_mobspawners 2017-07-06 15:23:16 +02:00
Wuzzy 0d6b57c9c4 Fix mob spawner icon not shown in gen'd spawners 2017-05-25 07:34:53 +02:00
Wuzzy 7ce80bada5 Update error msg 2017-05-25 06:12:22 +02:00
Wuzzy c1c15eb60b Rename mcl_monster_spawners to mcl_mobspawners.
Sorry for the trouble, but the long name annoyed me. :P
2017-05-25 06:09:03 +02:00