FOSS
/
BangleApps
mirror of https://github.com/espruino/BangleApps
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Fix 'srcs' being defined in global scope

pull/2381/head
Gordon Williams 2022-12-09 10:32:45 +00:00
parent d33106bc8f
commit 117560ffed
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/widmessages/ChangeLog
View File

@ -1 +1,2 @@
0.01: Moved messages widget into standalone widget app 0.01: Moved messages widget into standalone widget app
0.02: Fix 'srcs' being defined in global scope

2
apps/widmessages/metadata.json
View File

@ -1,7 +1,7 @@
{ {
"id": "widmessages", "id": "widmessages",
"name": "Message Widget", "name": "Message Widget",
"version": "0.01", "version": "0.02",
"description": "Widget showing new messages", "description": "Widget showing new messages",
"icon": "app.png", "icon": "app.png",
"type": "widget", "type": "widget",

3
apps/widmessages/widget.js
View File

@ -18,7 +18,7 @@
if (!this.width) return; if (!this.width) return;
let settings = Object.assign({flash: true, maxMessages: 3}, require("Storage").readJSON("messages.settings.json", true) || {}); let settings = Object.assign({flash: true, maxMessages: 3}, require("Storage").readJSON("messages.settings.json", true) || {});
if (recall!==true || settings.flash) { if (recall!==true || settings.flash) {
const msgsShown = E.clip(this.srcs.length, 0, settings.maxMessages), const msgsShown = E.clip(this.srcs.length, 0, settings.maxMessages);
srcs = Object.keys(this.srcs); srcs = Object.keys(this.srcs);
g.reset().clearRect(this.x, this.y, this.x+this.width, this.y+23); g.reset().clearRect(this.x, this.y, this.x+this.width, this.y+23);
for(let i = 0; i<msgsShown; i++) { for(let i = 0; i<msgsShown; i++) {
@ -68,6 +68,5 @@
}; };
Bangle.on("message", WIDGETS["messages"].onMsg); Bangle.on("message", WIDGETS["messages"].onMsg);
this.srcs = {};
WIDGETS["messages"].onMsg("init", {}); // abuse type="init" to prevent Bangle.drawWidgets(); WIDGETS["messages"].onMsg("init", {}); // abuse type="init" to prevent Bangle.drawWidgets();
})(); })();