Bram
/
ns_cavegen
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Set world height is limited by MineClone2 bug #3

New Issue
Closed
opened 2024-05-01 07:39:06 +00:00 by Bram · 2 comments
Bram commented 2024-05-01 07:39:06 +00:00
Owner

Setting the world height to -1000 causes problems with MineClone2 generating dungeons too close near the edge. There is a chunk with a max size between -993 and -995, which is too little space for MineClone2 to generate caves.

However, since MineClone2 doesn't check for invalid values, an error can be caused if the margin of the cave is larger than the available space in the chunk.

Commit 57874f4dfb contains a fix for this issue, but it hasn't yet merged into the main branch.

Setting the world height to -1000 causes problems with MineClone2 generating dungeons too close near the edge. There is a chunk with a max size between -993 and -995, which is too little space for MineClone2 to generate caves. However, since MineClone2 doesn't check for invalid values, an error can be caused if the margin of the cave is larger than the available space in the chunk. Commit https://git.noordstar.me/Bram/MineClone2/commit/57874f4dfbabd7ca3835a34918fa50795b9015b4 contains a fix for this issue, but it hasn't yet merged into the main branch.
Bram commented 2024-05-02 07:21:46 +00:00
Poster
Owner

A pull request has been made at Fix dungeon margin bug #4276. It is currently awaiting tests.

A pull request has been made at [Fix dungeon margin bug #4276](https://git.minetest.land/MineClone2/MineClone2/pulls/4276/files). It is currently awaiting tests.
Bram commented 2024-05-21 07:52:42 +00:00
Poster
Owner

The pull request has been accepted and the bug now no longer exists.

The pull request has been accepted and the bug now no longer exists.
Bram closed this issue 2024-05-21 07:52:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
1.0.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bram/ns_cavegen#3
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?