Bram
/
noordstar_caves
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Finish cave generation refactor #1

Merged
Bram merged 6 commits from refactor-end into main 2024-04-30 15:15:05 +00:00
Conversation 0 Commits 6 Files Changed 5
Bram commented 2024-04-30 15:04:38 +00:00
Owner

This pull request is a more efficient rewrite of the repository that makes the code more readable, contained within a single file and significantly improves performance from 5 seconds per chunk to ~500ms per chunk.

This pull request is a more efficient rewrite of the repository that makes the code more readable, contained within a single file and significantly improves performance from 5 seconds per chunk to ~500ms per chunk.
Bram added 6 commits 2024-04-30 15:04:38 +00:00
7b29f68ffa Move initial parts over to init.lua 
Since `dofile` is a global variable, it cannot be securely trusted for imports.

Additionally, I learnt recently that local functions can be referenced more clearly in a file by adding them as methods to a local table.

https://social.noordstar.me/notes/9sfk6273ao
Bram merged commit cec1e94129 into main 2024-04-30 15:15:05 +00:00
Bram deleted branch refactor-end 2024-04-30 15:15:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Bram/noordstar_caves#1
There is no content yet.
Delete Branch "refactor-end"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?