Bram
/
MineClone2
1
0
Fork 0
Code Pull Requests Activity
7,453 Commits
85 Branches
80 Tags
173 MiB
Commit Graph

6827 Commits (22edd083875f18b50daa250fead3f7c1e8bfbd3e)

Author SHA1 Message Date
Nils Dagsson Moskopp 41550da87b Fix redstone comparator flooding crash 
Redstone comparators have two modes, comparison mode & subtraction mode.
Before this patch, the functions to turn comparators on or off attempted
to swap nodes with comparators in the same mode, but failed to determine
the correct replacement node, if the existing node was not a comparator.

When a comparator in an on state (e.g. powered by a filled cauldron) was
flooded, the flooding dropped the comparator and replaced the comparator
node that was to be swapped out with air, which lead to a server crash.

This patch changes the functions that turn comparators on or off so they
only swap existing nodes with comparators in the same mode if the name
of the replacement node can be determined – i.e. if it is not nil.
 2022-02-24 15:52:01 +01:00
AFCMS cbfc71705d
remove blender backup file 2022-02-24 10:16:47 +01:00
kabou 5431e206b0 Fix hopper breakage in get_item_group return value. 
In commit 55009c257e that added vectors to
mcl_composters, mcl_hoppers was accidentally patched with a unrelated
change, updating it to get_item_group().  This mostly works, but in one
particular case the semantics of the return value differs.  Instead of
returning 'nil' it returns '0'.  That altered the evaluation of an if
condition, breaking the abm that sucks in items.

This commit fixes the conditional by explicitly comparing  '~= 0'.
 2022-02-24 03:18:25 +01:00
Emojigit 06deb92dd6 mcl_tools 2022-02-23 23:58:05 +01:00
Emojigit 7685b4758f mcl_flowers 2022-02-23 23:58:05 +01:00
Emojigit 9944abb328 mcl_books 2022-02-23 23:58:05 +01:00
Emojigit 5ce1852c1d mcl_dye 2022-02-23 23:58:05 +01:00
Emojigit 56a70025b8 mcl_flowerpots 2022-02-23 23:58:05 +01:00
Emojigit 9fe3bbd2fa mcl_mushrooms 2022-02-23 23:58:05 +01:00
Emojigit fb1d189d40 mcl_doors 2022-02-23 23:58:05 +01:00
Emojigit 9cd24f4af5 mcl_commands 2022-02-23 23:58:05 +01:00
Emojigit a64c3f87bc xpanes 2022-02-23 23:58:05 +01:00
Emojigit 5075f2ca56 mcl_armor 2022-02-23 23:58:05 +01:00
Emojigit 249dfac319 mcl_inventory 2022-02-23 23:58:05 +01:00
Emojigit 2b5a0242db mcl_fire 2022-02-23 23:58:05 +01:00
Emojigit 790ccf0812 mcl_fishing 2022-02-23 23:58:05 +01:00
Emojigit 8d639794f3 mcl_fences 2022-02-23 23:58:05 +01:00
Emojigit af8681c143 mcl_buckets 2022-02-23 23:58:05 +01:00
Emojigit 1ef58f7250 mcl_walls 2022-02-23 23:58:05 +01:00
Emojigit 15747220f2 mcl_hoppers 2022-02-23 23:58:05 +01:00
Emojigit 925dad7f5e mcl_anvils 2022-02-23 23:58:05 +01:00
Emojigit 729f653c85 mcl_portals 2022-02-23 23:58:05 +01:00
Emojigit d1e328e57a mcl_bows 2022-02-23 23:58:05 +01:00
Emojigit 615a968fbb mcl_skins 2022-02-23 23:58:05 +01:00
Emojigit 7e5a9bd8b6 mcl_throwing 2022-02-23 23:58:05 +01:00
Emojigit d018bee00a mcl_cake 2022-02-23 23:58:05 +01:00
Emojigit 1365d0b257 mcl_jukebox 2022-02-23 23:58:05 +01:00
Emojigit a289a00427 mcl_heads 2022-02-23 23:58:05 +01:00
Emojigit a238aabbb0 mcl_cauldrons 2022-02-23 23:58:05 +01:00
Emojigit b02f7cd974 mcl_mobs 2022-02-23 23:58:05 +01:00
Emojigit e19113d4e0 findbiome 2022-02-23 23:58:05 +01:00
Emojigit 4deac632e6 mcl_sponges 2022-02-23 23:58:05 +01:00
Emojigit c480e6891d mcl_maps 2022-02-23 23:58:05 +01:00
Emojigit 844eb3fb7c mcl_brewing 2022-02-23 23:58:05 +01:00
Emojigit fc768cb1ad mcl_signs 2022-02-23 23:58:05 +01:00
Emojigit 1f9a919459 mcl_monster_eggs 2022-02-23 23:58:05 +01:00
Emojigit 70007e3453 mcl_furnaces 2022-02-23 23:58:05 +01:00
Emojigit 3aff1f8981 mcl_hunger 2022-02-23 23:58:05 +01:00
Emojigit c86a506672 mcl_tnt 2022-02-23 23:58:05 +01:00
Emojigit f348223da2 mcl_crafting_table 2022-02-23 23:58:05 +01:00
Emojigit ca6469b959 mcl_weather 2022-02-23 23:58:05 +01:00
Emojigit c52e09ddcd mcl_structures 2022-02-23 23:58:05 +01:00
Emojigit bb55120adc mcl_experience 2022-02-23 23:58:05 +01:00
Emojigit 77339afbe2 mcl_cocoas 2022-02-23 23:58:05 +01:00
Emojigit 9b15599bee hudbars 2022-02-23 23:58:05 +01:00
Emojigit a685c3bc83 mclx_core 2022-02-23 23:58:05 +01:00
Emojigit b01d4eba88 mcl_paintings 2022-02-23 23:58:05 +01:00
Emojigit 952747d4da mcl_mobspawners 2022-02-23 23:58:05 +01:00
Emojigit 430f5b05ab mcl_itemframes 2022-02-23 23:58:05 +01:00
Emojigit e4a311e28a mcl_clock 2022-02-23 23:58:05 +01:00
Emojigit 6a115a68ef mcl_armor_stand 2022-02-23 23:58:05 +01:00
Emojigit f3d0ec845c mcl_spawn 2022-02-23 23:58:05 +01:00
Emojigit 563daeed8a mcl_wip 2022-02-23 23:58:05 +01:00
Emojigit a6c3cab791 mclx_fences 2022-02-23 23:58:05 +01:00
Emojigit bb4ddee570 mcl_compass 2022-02-23 23:58:05 +01:00
Emojigit fe3e80bc0e lightning 2022-02-23 23:58:05 +01:00
Emojigit 59fe078fd7 mcl_playerplus 2022-02-23 23:58:05 +01:00
Emojigit dba08ddc1f mcl_torches 2022-02-23 23:58:05 +01:00
Emojigit 551bf917e2 mcl_void_damage 2022-02-23 23:58:05 +01:00
Emojigit 26dadb1846 mcl_falling_nodes 2022-02-23 23:58:05 +01:00
Emojigit 33a353e20d mcl_privs 2022-02-23 23:58:05 +01:00
Emojigit f02f3c9f40 screwdriver 2022-02-23 23:58:05 +01:00
Emojigit 410c1ecd1f mcl_hbarmor 2022-02-23 23:58:05 +01:00
Emojigit ba172f0847 mcl_explosions 2022-02-23 23:58:05 +01:00
Emojigit ad42c3588b mcl_farming 2022-02-23 23:58:05 +01:00
Emojigit 9734c74c56 (WIP) mcl_farming 2022-02-23 23:58:05 +01:00
Emojigit c3dd5e6c2c MORE MESS SORRY XD 2022-02-23 23:58:05 +01:00
Emojigit 21808390f9 Revert "add translates for `mcl_boats`" 
This reverts commit 2ee84f2ad3.
 2022-02-23 23:58:05 +01:00
Emojigit cc87791327 add translates for `mcl_boats` 
Co-authored-by: Emojigit <emojigit@noreply.git.minetest.land>
 2022-02-23 23:58:04 +01:00
Emojigit a8aabb2329 add translate for `doc_identifier` 2022-02-23 23:58:04 +01:00
Emojigit 4f00b62a18 add zh_TW translate to `mcl_beds` and `mcl_core` 2022-02-23 23:58:04 +01:00
AFCMS 360a1604ba
Revert "move barrels to mcl_chests" 
This reverts commit a272322cb5.
 2022-02-22 20:20:21 +01:00
AFCMS 61f4c5b885
apply @kay27 fix to `mcl_util.drop_items_from_meta_container` 2022-02-22 18:08:26 +01:00
AFCMS a272322cb5
move barrels to mcl_chests 2022-02-22 18:08:25 +01:00
AFCMS 9112915ddd
fix barrel top texture rotation 2022-02-22 18:08:25 +01:00
AFCMS 397c243e89
cleanup barrel TODO list 2022-02-22 18:08:25 +01:00
AFCMS c64d0e4558
simplify random dropping position code 2022-02-22 18:08:24 +01:00
AFCMS 61e54ed617
rename `mcl_util.drop_items_container_get` to `drop_items_from_meta_container` 2022-02-22 18:08:24 +01:00
AFCMS 0988637ea1
add barrel tooltip help text 2022-02-22 18:08:24 +01:00
AFCMS b88060dbfb
add doc description to barrels 2022-02-22 18:08:23 +01:00
AFCMS e3e06b4a4b
fix broken tree placement 2022-02-22 18:08:23 +01:00
AFCMS 34b445b04a
fixes 2022-02-22 18:08:22 +01:00
AFCMS d41a836514
add craft 2022-02-22 18:08:22 +01:00
AFCMS 80fb59f9ac
add barrel 2022-02-22 18:08:22 +01:00
cora a9357f7380 Do not send redundant bone position and properties 2022-02-22 11:15:56 +00:00
kabou af132cc523 Reinstate nil check in on_place_bucket. 
* Oops, nil checks on registered_node[name] were erroneously optimized
  away, risking crashes.  Reinstate those checks.
 2022-02-21 18:00:56 +01:00
kabou e54502edd6 Add more local aliases for minetest.* namespace functions 
* Add locals for
  - minetest.is_creative_enabled
  - minetest.is_protected
  - minetest.record_protection_violation
 2022-02-20 20:24:55 +01:00
kabou 639bf936c5 Use alias for minetest.* namespace function call. 
* Fix one missed minetest.get_node use in earlier commit.
 2022-02-20 19:52:05 +01:00
kabou d2261426c3 Remove redundant variables in on_place_bucket. 
The function on_place_bucket defined a couple of variables that were
used only once or in a redundant check.  After removal of the redundant
check in a previous commit, all use-once variables can now be substituted
with their assignment expressions.
 2022-02-20 18:46:23 +01:00
kabou 88ce1e3662 Remove redundant logic. 
The function on_place_bucket contains the following logic:
  if not a and not b then return x end
  if a then
    foo(a)
  elseif b then
    foo(b)
  else
    return x
  end

The "if not a and not b then .." is removed because the case is handled
by the else case later on.  This will allow some further simplifications.
 2022-02-20 18:46:23 +01:00
kabou b3aed9d6b8 Use proper get_item_group accessor. 
Instead of directly accessing the group table in node definitions, use
the proper minetest.get_item_group accessor to test for "cauldron"
group.
Also adds local alias get_item_group for the global minetest call.
 2022-02-20 18:46:23 +01:00
kabou 13baa68b67 Fixed missed alias uses and added set_node alias. 
Two instances of add_node and add_item still used the full minetest
call, substitute the alias.
Added a set_node alias for several minetest.set_node calls.
 2022-02-20 18:46:23 +01:00
kabou 315f251584 Add local to speedup global function access. 
The minetest.registered_nodes function is called from multiple places.
Define a local alias registered_nodes and substitute it in all calls.
 2022-02-20 18:46:23 +01:00
kabou 584a75df76 Fix filling cauldrons with water. 
When using a bucket of water on a cauldron, this would not fill the
cauldron as expected, but deposit a water source block on top of the
cauldron instead.

Applied patch from mineclone5 #38 (commit #
698c29733f06a7fcb7e755bf26ee46b33b00699b) from mineclone5 that fixes
this problem.
 2022-02-20 18:46:23 +01:00
kabou 8d18ab8a7a Optimize texture files. 
* Texture files were optimized with 'optipng  -o7 -zm9 -strip all' .
 2022-02-19 21:18:01 +01:00
kabou f81980da51 Fix hardness and blast resistance. 
* Use correct MC values for hardness and blast resistance.
 2022-02-19 21:18:01 +01:00
kabou 55009c257e Use new vectors 
* Use vector.new instead of xyz table.
 2022-02-19 21:18:01 +01:00
kabou 51ca60c097 Change custom node attribute name. 
* Rename _compost_level to _mcl_compost_level
 2022-02-19 21:18:01 +01:00
kabou f22baafaa6 Add player object check. 
* Add one more check if player object is an actual player.
 2022-02-19 21:18:01 +01:00
kabou ffc2c94096 Add help alias 
* Add help alias for the ready type composter
 2022-02-19 21:18:01 +01:00