[mcl_weather] fix warnings

mods/ENVIRONMENT/mcl_weather/skycolor.lua

@@ -205,8 +205,8 @@ mcl_weather.skycolor = {
 		-- Returns first player sky color. I assume that all players are in same color layout.
 		get_current_bg_color = function()
 			local players = mcl_weather.skycolor.utils.get_players(nil)
-			for _, player in ipairs(players) do
-				return player:get_sky()
+			if players[1] then
+				return players[1]:get_sky()
 			end
 			return nil
 		end

mods/ENVIRONMENT/mcl_weather/snow.lua

@@ -9,8 +9,8 @@ mcl_weather.snow.init_done = false
 mcl_weather.snow.add_snow_particles = function(player)
 	mcl_weather.rain.last_rp_count = 0
 	for i=mcl_weather.snow.particles_count, 1,-1 do
-    local random_pos_x, random_pos_y, random_pos_z = mcl_weather.get_random_pos_by_player_look_dir(player)
-    random_pos_y = math.random() + math.random(player:get_pos().y - 1, player:get_pos().y + 7)
+		local random_pos_x, _, random_pos_z = mcl_weather.get_random_pos_by_player_look_dir(player)
+		local random_pos_y = math.random() + math.random(player:get_pos().y - 1, player:get_pos().y + 7)
 		if minetest.get_node_light({x=random_pos_x, y=random_pos_y, z=random_pos_z}, 0.5) == 15 then
 			mcl_weather.rain.last_rp_count = mcl_weather.rain.last_rp_count + 1
 			minetest.add_particle({
@@ -45,13 +45,13 @@ mcl_weather.snow.set_sky_box = function()
 	mcl_weather.skycolor.active = true
 end
 
-mcl_weather.snow.clear = function() 
+function mcl_weather.snow.clear()
 	mcl_weather.skycolor.remove_layer("weather-pack-snow-sky")
 	mcl_weather.snow.init_done = false
 end
 
 -- Simple random texture getter
-mcl_weather.snow.get_texture = function()
+function mcl_weather.snow.get_texture()
 	return "weather_pack_snow_snowflake"..math.random(1,2)..".png"
 end
 

mods/ENVIRONMENT/mcl_weather/thunder.lua

@@ -19,29 +19,27 @@ minetest.register_globalstep(function(dtime)
 	mcl_weather.rain.make_weather()
 
 	if mcl_weather.thunder.init_done == false then
-    mcl_weather.skycolor.add_layer(
-      "weather-pack-thunder-sky",
-      {{r=0, g=0, b=0},
+		mcl_weather.skycolor.add_layer("weather-pack-thunder-sky", {
+			{r=0, g=0, b=0},
 			{r=40, g=40, b=40},
 			{r=85, g=86, b=86},
 			{r=40, g=40, b=40},
-      {r=0, g=0, b=0}})
+			{r=0, g=0, b=0},
+		})
 		mcl_weather.skycolor.active = true
 		for _, player in pairs(get_connected_players()) do
 			player:set_clouds({color="#3D3D3FE8"})
 		end
 		mcl_weather.thunder.init_done = true
 	end
-  
 	if (mcl_weather.thunder.next_strike <= minetest.get_gametime()) then
 		lightning.strike()
 		local delay = math.random(mcl_weather.thunder.min_delay, mcl_weather.thunder.max_delay)
 		mcl_weather.thunder.next_strike = minetest.get_gametime() + delay
 	end
-
 end)
 
-mcl_weather.thunder.clear = function()
+function mcl_weather.thunder.clear()
 	mcl_weather.rain.clear()
 	mcl_weather.skycolor.remove_layer("weather-pack-thunder-sky")
 	mcl_weather.skycolor.remove_layer("lightning")
@@ -58,6 +56,6 @@ if mcl_weather.reg_weathers.thunder == nil then
 		max_duration = 1200,
 		transitions = {
 			[100] = "rain",
-    }
+		},
 	}
 end

mods/ENVIRONMENT/mcl_weather/weather_core.lua

@@ -1,5 +1,7 @@
 local S = minetest.get_translator("mcl_weather")
 
+local math = math
+
 -- weather states, 'none' is default, other states depends from active mods
 mcl_weather.state = "none"
 
@@ -96,9 +98,7 @@ mcl_weather.get_random_pos_by_player_look_dir = function(player)
 	local look_dir = player:get_look_dir()
 	local player_pos = player:get_pos()
 
-	local random_pos_x = 0
-	local random_pos_y = 0
-	local random_pos_z = 0
+	local random_pos_x, random_pos_y, random_pos_z
 
 	if look_dir.x > 0 then
 		if look_dir.z > 0 then