Merge pull request #2615 from halemmerich/messageoverlay

messagesoverlay - Fix handlers being restored incorrectly if message removed

apps/messagesoverlay/ChangeLog

@@ -1 +1,2 @@
 0.01: Initial fork from messages_light
+0.02: Fix touch/drag/swipe handlers not being restored correctly if a message is removed

apps/messagesoverlay/lib.js

@@ -389,19 +389,17 @@ let getTouchHandler = function(ovr){
   };
 };
 
-let touchHandler;
-let swipeHandler;
-
 let restoreHandler = function(event){
-  if (backup[event]){
+  LOG("Restore", event, backup[event]);
-    Bangle["#on" + event]=backup[event];
+  Bangle.removeAllListeners(event);
-    backup[event] = undefined;
+  Bangle["#on" + event]=backup[event];
-  }
+  backup[event] = undefined;
 };
 
 let backupHandler = function(event){
-  if (eventQueue.length > 1 && ovr) return; // do not backup, overlay is already up
+  if (backupDone) return; // do not backup, overlay is already up
   backup[event] = Bangle["#on" + event];
+  LOG("Backed up", backup[event]);
   Bangle.removeAllListeners(event);
 };
 
@@ -414,21 +412,16 @@ let cleanup = function(){
   restoreHandler("swipe");
   restoreHandler("drag");
 
-  if (touchHandler) {
-    Bangle.removeListener("touch", touchHandler);
-    touchHandler = undefined;
-  }
-  if (swipeHandler) {
-    Bangle.removeListener("swipe", swipeHandler);
-    swipeHandler = undefined;
-  }
   Bangle.setLCDOverlay();
+  backupDone = false;
   ovr = undefined;
   quiet = undefined;
 };
 
 let backup = {};
 
+let backupDone = false;
+
 let main = function(ovr, event) {
   LOG("Main", event, settings);
 
@@ -441,13 +434,11 @@ let main = function(ovr, event) {
   backupHandler("touch");
   backupHandler("swipe");
   backupHandler("drag");
-
+  if (!backupDone){
-  if (touchHandler) Bangle.removeListener("touch",touchHandler);
+    Bangle.on('touch', getTouchHandler(ovr));
-  if (swipeHandler) Bangle.removeListener("swipe",swipeHandler);
+    Bangle.on('swipe', getSwipeHandler(ovr));
-  touchHandler = getTouchHandler(ovr);
+  }
-  swipeHandler = getSwipeHandler(ovr);
+  backupDone=true;
-  Bangle.on('touch', touchHandler);
-  Bangle.on('swipe', swipeHandler);
 
   if (event !== undefined){
     drawBorder(ovr);

apps/messagesoverlay/metadata.json

@@ -1,7 +1,7 @@
 {
   "id": "messagesoverlay",
   "name": "Messages Overlay",
-  "version": "0.01",
+  "version": "0.02",
   "description": "An overlay based implementation of a messages UI (display notifications from iOS and Gadgetbridge/Android)",
   "icon": "app.png",
   "type": "bootloader",
@@ -10,7 +10,6 @@
   "dependencies" : { "messageicons":"module","messages":"app" },
   "readme": "README.md",
   "storage": [
-    {"name":"messagesoverlay.settings.js","url":"settings.js"},
     {"name":"messagesoverlay","url":"lib.js"},
     {"name":"messagesoverlay.boot.js","url":"boot.js"}
   ],

apps/messagesoverlay/settings.js

@@ -1 +0,0 @@
-eval(require("Storage").read("messages.settings.js"));