1
0
Fork 0

messagesoverlay - Fix handlers being restored incorrectly if message removed

master
Martin Boonk 2023-02-27 23:31:10 +01:00
parent 625e52514d
commit 43448e42c9
3 changed files with 15 additions and 25 deletions

View File

@ -1 +1,2 @@
0.01: Initial fork from messages_light
0.02: Fix touch/drag/swipe handlers not being restored correctly if a message is removed

View File

@ -389,19 +389,17 @@ let getTouchHandler = function(ovr){
};
};
let touchHandler;
let swipeHandler;
let restoreHandler = function(event){
if (backup[event]){
LOG("Restore", event, backup[event]);
Bangle.removeAllListeners(event);
Bangle["#on" + event]=backup[event];
backup[event] = undefined;
}
};
let backupHandler = function(event){
if (eventQueue.length > 1 && ovr) return; // do not backup, overlay is already up
if (backupDone) return; // do not backup, overlay is already up
backup[event] = Bangle["#on" + event];
LOG("Backed up", backup[event]);
Bangle.removeAllListeners(event);
};
@ -414,21 +412,16 @@ let cleanup = function(){
restoreHandler("swipe");
restoreHandler("drag");
if (touchHandler) {
Bangle.removeListener("touch", touchHandler);
touchHandler = undefined;
}
if (swipeHandler) {
Bangle.removeListener("swipe", swipeHandler);
swipeHandler = undefined;
}
Bangle.setLCDOverlay();
backupDone = false;
ovr = undefined;
quiet = undefined;
};
let backup = {};
let backupDone = false;
let main = function(ovr, event) {
LOG("Main", event, settings);
@ -441,13 +434,9 @@ let main = function(ovr, event) {
backupHandler("touch");
backupHandler("swipe");
backupHandler("drag");
if (touchHandler) Bangle.removeListener("touch",touchHandler);
if (swipeHandler) Bangle.removeListener("swipe",swipeHandler);
touchHandler = getTouchHandler(ovr);
swipeHandler = getSwipeHandler(ovr);
Bangle.on('touch', touchHandler);
Bangle.on('swipe', swipeHandler);
backupDone=true;
Bangle.on('touch', getTouchHandler(ovr));
Bangle.on('swipe', getSwipeHandler(ovr));
if (event !== undefined){
drawBorder(ovr);

View File

@ -1,7 +1,7 @@
{
"id": "messagesoverlay",
"name": "Messages Overlay",
"version": "0.01",
"version": "0.02",
"description": "An overlay based implementation of a messages UI (display notifications from iOS and Gadgetbridge/Android)",
"icon": "app.png",
"type": "bootloader",