From fe2bb7c0cf676cb2476196034986f65478aea4b5 Mon Sep 17 00:00:00 2001 From: Marco H Date: Thu, 19 Jan 2023 13:54:46 +0100 Subject: [PATCH] Fix potential NPE --- loader.js | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/loader.js b/loader.js index 2aaad0350..414aa99d1 100644 --- a/loader.js +++ b/loader.js @@ -249,23 +249,27 @@ window.addEventListener('load', (event) => { // BLE Compatibility var selectBLECompat = document.getElementById("settings-ble-compat"); - Puck.increaseMTU = !SETTINGS.bleCompat; - selectBLECompat.checked = !!SETTINGS.bleCompat; - selectBLECompat.addEventListener("change",event=>{ - console.log("BLE compatibility mode "+(event.target.checked?"on":"off")); - SETTINGS.bleCompat = event.target.checked; + if (selectBLECompat) { Puck.increaseMTU = !SETTINGS.bleCompat; - saveSettings(); - }); + selectBLECompat.checked = !!SETTINGS.bleCompat; + selectBLECompat.addEventListener("change",event=>{ + console.log("BLE compatibility mode "+(event.target.checked?"on":"off")); + SETTINGS.bleCompat = event.target.checked; + Puck.increaseMTU = !SETTINGS.bleCompat; + saveSettings(); + }); + } // Sending usage stats var selectUsageStats = document.getElementById("settings-usage-stats"); - selectUsageStats.checked = !!SETTINGS.sendUsageStats; - selectUsageStats.addEventListener("change",event=>{ - console.log("Send Usage Stats "+(event.target.checked?"on":"off")); - SETTINGS.sendUsageStats = event.target.checked; - saveSettings(); - }); + if (selectUsageStats) { + selectUsageStats.checked = !!SETTINGS.sendUsageStats; + selectUsageStats.addEventListener("change",event=>{ + console.log("Send Usage Stats "+(event.target.checked?"on":"off")); + SETTINGS.sendUsageStats = event.target.checked; + saveSettings(); + }); + } // Load language list httpGet("lang/index.json").then(languagesJSON=>{