From f1d0bf4d62c4f434c61df01d4ad75b9790dd0699 Mon Sep 17 00:00:00 2001
From: Rob Pilling <robpilling@gmail.com>
Date: Sun, 11 Jun 2023 12:59:01 +0100
Subject: [PATCH] sanitycheck: look for untracked setting files

---
 bin/sanitycheck.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/bin/sanitycheck.js b/bin/sanitycheck.js
index f2e5b9877..a6e85cc4f 100755
--- a/bin/sanitycheck.js
+++ b/bin/sanitycheck.js
@@ -253,6 +253,10 @@ apps.forEach((app,appIdx) => {
         if (a>=0 && b>=0 && a<b)
           WARN(`Clock ${app.id} file calls loadWidgets before setUI (clock widget/etc won't be aware a clock app is running)`, {file:appDirRelative+file.url, line : fileContents.substr(0,a).split("\n").length});
       }
+      // if settings, suggest adding to datafiles
+      if (file.name.endsWith("setting.js") && !app.data || app.data.every(d => !d.name || !d.name.endsWith(".json"))) {
+        WARN(`App ${app.id} has a setting file but no corresponding data entry (add \`"data":[{"name":"${app.id}.settings.json"}]\`)`, {file:appDirRelative+file.url});
+      }
     }
     for (const key in file) {
       if (!STORAGE_KEYS.includes(key)) ERROR(`App ${app.id} file ${file.name} has unknown key ${key}`, {file:appDirRelative+file.url});