From 607eb372802cc4b77bbb2516794e09452bce5715 Mon Sep 17 00:00:00 2001 From: deirdreobyrne Date: Tue, 2 Apr 2024 12:28:03 +0100 Subject: [PATCH 1/3] New bug in bigdclock.app.js The value of "width" was being reset somewhere. So "width" has been renamed to "batteryUsedWidth", which is better anyway. --- apps/bigdclock/bigdclock.app.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/apps/bigdclock/bigdclock.app.js b/apps/bigdclock/bigdclock.app.js index 3f8607495..0ebc33bed 100644 --- a/apps/bigdclock/bigdclock.app.js +++ b/apps/bigdclock/bigdclock.app.js @@ -12,7 +12,7 @@ Graphics.prototype.setFontOpenSans = function(scale) { var drawTimeout; var lastBattCheck = 0; -var width = 0; +var batteryUsedWidth = 0; function queueDraw(millis_now) { if (drawTimeout) clearTimeout(drawTimeout); @@ -32,8 +32,8 @@ function draw() { if ((date.getTime() >= lastBattCheck + 15*60000) || Bangle.isCharging()) { lastBattCheck = date.getTime(); - width = E.getBattery(); - width += width/2; + batteryUsedWidth = E.getBattery(); + batteryUsedWidth += batteryUsedWidth/2; } g.reset(); @@ -58,7 +58,7 @@ function draw() { g.fillRect(167,163,170,167); if (Bangle.isCharging()) { g.setColor(1,1,0); - g.fillRect(12,162,12+width,168); + g.fillRect(12,162,12+batteryUsedWidth,168); } else { g.setColor(1,0,0); g.fillRect(12,162,57,168); @@ -67,16 +67,16 @@ function draw() { g.setColor(0,1,0); g.fillRect(73,162,162,168); } - if (width < 150) { + if (batteryUsedWidth < 150) { g.setColor(g.theme.bg); - g.fillRect(12+width+1,162,162,168); + g.fillRect(12+batteryUsedWidth+1,162,162,168); } if (Bangle.isCharging()) { g.setColor(1,1,0); - } else if (width <= 45) { + } else if (batteryUsedWidth <= 45) { g.setColor(1,0,0); - } else if (width <= 60) { + } else if (batteryUsedWidth <= 60) { g.setColor(1,1,0); } else { g.setColor(0, 1, 0); From b608533e17dc271a5963e794165a6fcd58818c5f Mon Sep 17 00:00:00 2001 From: deirdreobyrne Date: Tue, 2 Apr 2024 12:46:24 +0100 Subject: [PATCH 2/3] Update metadata.json Version bump. --- apps/bigdclock/metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/bigdclock/metadata.json b/apps/bigdclock/metadata.json index 54a4296bc..dc3bcb143 100644 --- a/apps/bigdclock/metadata.json +++ b/apps/bigdclock/metadata.json @@ -1,7 +1,7 @@ { "id": "bigdclock", "name": "Big digit clock containing just the essentials", "shortName":"Big digit clk", - "version": "0.08", + "version": "0.09", "description": "A clock containing just the essentials, made as easy to read as possible for those of us that need glasses. It contains the time, the day-of-week, the day-of-month, and the current battery state-of-charge.", "icon": "bigdclock.png", "type": "clock", From 7e929de2e7cb7dd54ea7efc54a0092b0ea08f25b Mon Sep 17 00:00:00 2001 From: deirdreobyrne Date: Tue, 2 Apr 2024 12:48:01 +0100 Subject: [PATCH 3/3] Update ChangeLog Changes in v0.09 --- apps/bigdclock/ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/bigdclock/ChangeLog b/apps/bigdclock/ChangeLog index 9af3b7ea8..4089c823d 100644 --- a/apps/bigdclock/ChangeLog +++ b/apps/bigdclock/ChangeLog @@ -6,3 +6,4 @@ 0.06: Tell clock widgets to hide. 0.07: Better battery graphic - now has green, yellow and red sections; battery status reflected in the bar across the middle of the screen; current battery state checked only once every 15 minutes, leading to longer-lasting battery charge 0.08: Minor code improvements +0.09: Something was changing the value of the "width" variable, which caused the battery usage feature to malfunction. The "width" variable has been renamed - the cause remains a mystery.