From cc0ac4e3f566a9485fa8e73c53992e7ce2b8e3d6 Mon Sep 17 00:00:00 2001
From: Kevin Whitaker <eyecreate@eyecreate.org>
Date: Sat, 25 Mar 2023 17:46:41 -0400
Subject: [PATCH] fix setting screen

---
 apps/nesclock/settings.js | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/apps/nesclock/settings.js b/apps/nesclock/settings.js
index 357c76464..0bbecc2ce 100644
--- a/apps/nesclock/settings.js
+++ b/apps/nesclock/settings.js
@@ -1,6 +1,5 @@
 (function(back) {
   var FILE = "nesclock.json";
-  // Load settings
   var settings = Object.assign({
     currentFace: "Mario 3",
   }, require('Storage').readJSON(FILE, true) || {});
@@ -8,7 +7,8 @@
   function writeSettings() {
     require('Storage').writeJSON(FILE, settings);
   }
-  
+
+  // Helper method which uses int-based menu item for set of string values
   function stringItems(startvalue, writer, values) {
     return {
       value: (startvalue === undefined ? 0 : values.indexOf(startvalue)),
@@ -22,16 +22,21 @@
         writeSettings();
       }
     };
-  }  
-  
+  }
+
+  // Helper method which breaks string set settings down to local settings object
   function stringInSettings(name, values) {
     return stringItems(settings[name], v => settings[name] = v, values);
   }
 
-  // Show the menu
-  E.showMenu({
-    "" : { "title" : "NES Clock" },
-    "< Back" : () => back(),
-    'Game Theme': stringInSettings("currentFace", ["Mario 3", "Mario 2", "Mario 1", "Kirby", "Zelda"]),
-  });
-})(load);
+  var mainmenu = {
+    "": {
+      "title": "NES Clock"
+    },
+    "< Back": () => back(),
+    "Game Theme": stringInSettings("currentFace", ["Mario 3", "Mario 2", "Mario 1", "Kirby", "Zelda"]),
+  };
+
+  E.showMenu(mainmenu);
+
+});