From bdaa9661cd900b7bc0ba8bdc6db9db056a1a0285 Mon Sep 17 00:00:00 2001
From: Richard de Boer <git@tubul.net>
Date: Wed, 7 Dec 2022 21:18:35 +0100
Subject: [PATCH] messages: erase messages file instead of writing empty []

for #2370
---
 apps/messages/ChangeLog     | 1 +
 apps/messages/lib.js        | 3 ++-
 apps/messages/metadata.json | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/apps/messages/ChangeLog b/apps/messages/ChangeLog
index 3df056d62..c9ff39bc4 100644
--- a/apps/messages/ChangeLog
+++ b/apps/messages/ChangeLog
@@ -1,2 +1,3 @@
 0.55: Moved messages library into standalone library
 0.56: Fix handling of music messages
+0.57: Optimize saving empty message list
diff --git a/apps/messages/lib.js b/apps/messages/lib.js
index e5c81f3fd..1679d8296 100644
--- a/apps/messages/lib.js
+++ b/apps/messages/lib.js
@@ -135,7 +135,8 @@ exports.toggleWidget = function(show) {
  * @param {array} messages Messages to save
  */
 exports.write = function(messages) {
-  require("Storage").writeJSON("messages.json", messages.map(m => {
+  if (!messages.length) require("Storage").erase("messages.json");
+  else require("Storage").writeJSON("messages.json", messages.map(m => {
     // we never want to save saved/handled status to file;
     delete m.saved;
     delete m.handled;
diff --git a/apps/messages/metadata.json b/apps/messages/metadata.json
index 27e771975..e424c3eed 100644
--- a/apps/messages/metadata.json
+++ b/apps/messages/metadata.json
@@ -1,7 +1,7 @@
 {
   "id": "messages",
   "name": "Messages",
-  "version": "0.56",
+  "version": "0.57",
   "description": "Library to handle, load and store message events received from Android/iOS",
   "icon": "app.png",
   "type": "module",