From 7a98c039e705e67db0f10e94c7623cc6769c7b78 Mon Sep 17 00:00:00 2001
From: Mika Dede <me@mde.de.com>
Date: Tue, 28 Sep 2021 15:47:19 +0200
Subject: [PATCH] score: fix settings module

---
 apps/score/score.settings.js | 83 ++++++++++++++++++------------------
 1 file changed, 41 insertions(+), 42 deletions(-)

diff --git a/apps/score/score.settings.js b/apps/score/score.settings.js
index 4a4b5e56a..c4e22e45d 100644
--- a/apps/score/score.settings.js
+++ b/apps/score/score.settings.js
@@ -1,46 +1,45 @@
-function fillSettingsWithDefaults(settings) {
-  if (settings.winSets == null) {
-    settings.winSets = 2;
-  }
-  if (settings.setsPerPage == null) {
-    settings.setsPerPage = 5;
-  }
-  if (settings.winScore == null) {
-    settings.winScore = 21;
-  }
-  if (settings.enableTwoAhead == null) {
-    settings.enableTwoAhead = true;
-  }
-  if (settings.enableMaxScore == null) {
-    settings.enableMaxScore = true;
-  }
-  if (settings.maxScore == null) {
-    settings.maxScore = 30;
-  }
-  if (settings.enableTennisScoring == null) {
-    settings.enableTennisScoring = false;
-  }
-
-  if (settings.enableMaxScoreTiebreak == null) {
-    settings.enableMaxScoreTiebreak = false;
-  }
-  if (settings.maxScoreTiebreakWinScore == null) {
-    settings.maxScoreTiebreakWinScore = 6;
-  }
-  if (settings.maxScoreTiebreakEnableTwoAhead == null) {
-    settings.maxScoreTiebreakEnableTwoAhead = true;
-  }
-  if (settings.maxScoreTiebreakEnableMaxScore == null) {
-    settings.maxScoreTiebreakEnableMaxScore = false;
-  }
-  if (settings.maxScoreTiebreakMaxScore == null) {
-    settings.maxScoreTiebreakMaxScore = 15;
-  }
-
-  return settings;
-}
-
 (function (back, inApp, ret) {
+  function fillSettingsWithDefaults(settings) {
+    if (settings.winSets == null) {
+      settings.winSets = 2;
+    }
+    if (settings.setsPerPage == null) {
+      settings.setsPerPage = 5;
+    }
+    if (settings.winScore == null) {
+      settings.winScore = 21;
+    }
+    if (settings.enableTwoAhead == null) {
+      settings.enableTwoAhead = true;
+    }
+    if (settings.enableMaxScore == null) {
+      settings.enableMaxScore = true;
+    }
+    if (settings.maxScore == null) {
+      settings.maxScore = 30;
+    }
+    if (settings.enableTennisScoring == null) {
+      settings.enableTennisScoring = false;
+    }
+
+    if (settings.enableMaxScoreTiebreak == null) {
+      settings.enableMaxScoreTiebreak = false;
+    }
+    if (settings.maxScoreTiebreakWinScore == null) {
+      settings.maxScoreTiebreakWinScore = 6;
+    }
+    if (settings.maxScoreTiebreakEnableTwoAhead == null) {
+      settings.maxScoreTiebreakEnableTwoAhead = true;
+    }
+    if (settings.maxScoreTiebreakEnableMaxScore == null) {
+      settings.maxScoreTiebreakEnableMaxScore = false;
+    }
+    if (settings.maxScoreTiebreakMaxScore == null) {
+      settings.maxScoreTiebreakMaxScore = 15;
+    }
+
+    return settings;
+  }
 
   const fileName = 'score.json';
   let settings = require('Storage').readJSON(fileName, 1) || {};