From 2b6f7765cc69db5e8dd34fa9ad86051914e26601 Mon Sep 17 00:00:00 2001 From: Gordon Williams Date: Thu, 8 Jun 2023 19:26:12 +0100 Subject: [PATCH] Fix buzz.js - whenever called this used to keep firing an interval every 100ms, and they would build up! --- apps/messages/ChangeLog | 1 + apps/messages/metadata.json | 2 +- modules/buzz.js | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/messages/ChangeLog b/apps/messages/ChangeLog index f08357673..416363c45 100644 --- a/apps/messages/ChangeLog +++ b/apps/messages/ChangeLog @@ -3,3 +3,4 @@ 0.57: Optimize saving empty message list 0.58: show/hide "messages" widget directly, instead of through library stub 0.59: fixes message timeout by using setinterval, as it was intended. So the buzz is triggered every x seconds until the timeout occours. +0.60: Bump version to allow new buzz.js module to be loaded - fixes memory/performance hog when buzz called diff --git a/apps/messages/metadata.json b/apps/messages/metadata.json index 00e95e44e..e8aacd976 100644 --- a/apps/messages/metadata.json +++ b/apps/messages/metadata.json @@ -1,7 +1,7 @@ { "id": "messages", "name": "Messages", - "version": "0.59", + "version": "0.60", "description": "Library to handle, load and store message events received from Android/iOS", "icon": "app.png", "type": "module", diff --git a/modules/buzz.js b/modules/buzz.js index aed0e2e7b..99364fc1a 100644 --- a/modules/buzz.js +++ b/modules/buzz.js @@ -16,7 +16,7 @@ */ exports.pattern = pattern => new Promise(resolve => { function doBuzz() { - if (pattern == "") resolve(); + if (pattern == "") return resolve(); var c = pattern[0]; pattern = pattern.substr(1); const BUZZ_WEAK = 0.25, BUZZ_STRONG = 1;