From ab42b6555fb8b52ca39f4179cc9a642f3a6f19ec Mon Sep 17 00:00:00 2001
From: storm64 <github@storm64.de>
Date: Mon, 14 Feb 2022 09:10:26 +0100
Subject: [PATCH] sleeplog: Fix to be able to switch logging as intended

Update lib.js
 - fix error in `setEnabled(...)` when logfile=false
Update settings.js
 - use correct value for settings.logfile
---
 apps/sleeplog/lib.js      | 5 ++---
 apps/sleeplog/settings.js | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/apps/sleeplog/lib.js b/apps/sleeplog/lib.js
index 6fd6d2ba9..1fbd3d2cb 100644
--- a/apps/sleeplog/lib.js
+++ b/apps/sleeplog/lib.js
@@ -5,9 +5,8 @@ exports = {
     if (typeof global.sleeplog !== "object") return;
 
     // set default logfile
-    logfile = logfile.endsWith(".log") ? logfile :
-      logfile === false ? undefined :
-      "sleeplog.log";
+    logfile = (typeof logfile === "string" && logfile.endsWith(".log")) ? logfile :
+      logfile === false ? undefined : "sleeplog.log";
 
     // stop if enabled
     if (global.sleeplog.enabled) global.sleeplog.stop();
diff --git a/apps/sleeplog/settings.js b/apps/sleeplog/settings.js
index c41980d00..24bd82f61 100644
--- a/apps/sleeplog/settings.js
+++ b/apps/sleeplog/settings.js
@@ -134,7 +134,7 @@
         format: v => v === true ? "default" : v ? "custom" : "off",
         onchange: function(v) {
           if (v !== "custom") {
-            settings.logfile = v ? "sleeplog.log" : undefined;
+            settings.logfile = v ? "sleeplog.log" : false;
             changeRestart();
           }
         }